Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the encrypt_decrypt_2 context method #220

Merged
merged 4 commits into from
Apr 29, 2021
Merged

Adds the encrypt_decrypt_2 context method #220

merged 4 commits into from
Apr 29, 2021

Conversation

Superhepper
Copy link
Collaborator

No description provided.

@Superhepper
Fixed missing item in SymmetricMode interface type
ee1a7b5 
Added the CBC mode to the SymmetricMode interface type.

Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
ionut-arm
ionut-arm reviewed Apr 10, 2021
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - missing docs on the new context method, but apart from that...

tss-esapi/tests/context_tests/tpm_commands/symmetric_primitives_tests.rs Outdated Show resolved Hide resolved
tss-esapi/src/interface_types/algorithm.rs
@@ -237,6 +237,7 @@ impl TryFrom<TPMI_ALG_SYM> for SymmetricAlgorithm {
pub enum SymmetricMode {
Ctr,
Ofb,
Cbc,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a breaking change - if it's in a different commit then it's alright. I'll try and think of a way to check whether the changes in a PR relate to breaking additions.

@Superhepper
Copy link
Collaborator Author

@ionut-arm Thanks for your input. Now I have to figure out what I am doing wrong in the test. I get a really wierd like unsupported key size error.

@ionut-arm
Copy link
Member

@ionut-arm Thanks for your input. Now I have to figure out what I am doing wrong in the test. I get a really wierd like unsupported key size error.

The unsupported key size is in relation to the first parameter, so TPM2B_SENSITIVE_CREATE. If you look at your initial_data (which is the initial value of the key, I think), you define it as vec![1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 16] which isn't 16 bytes long 😀 The same applies to a few other buffers below - you need to make them 16 bytes and then it works.

@Superhepper Superhepper force-pushed the decrypt_encrypt branch 4 times, most recently from ede5c42 to 05e3718 Compare April 14, 2021 17:05
@Superhepper Superhepper marked this pull request as ready for review April 14, 2021 17:06
ionut-arm
ionut-arm approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of typos

tss-esapi/src/context/tpm_commands/symmetric_primitives.rs Outdated Show resolved Hide resolved
tss-esapi/src/context/tpm_commands/symmetric_primitives.rs Outdated Show resolved Hide resolved
@Superhepper
Added support for symmetric ciphers in
6217278 
Tpm2PublicBuilder.

Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@Superhepper
Added encrypt_decrypt_2 api.
ebc3927 
Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@Superhepper
Added inprovments to the create context method
cacab32 
- Add more API documentation.
- Renamed a parameter in the method.

Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
@ionut-arm ionut-arm merged commit 5f3579d into parallaxsecond:main Apr 29, 2021
@Superhepper Superhepper deleted the decrypt_encrypt branch September 10, 2021 15:49
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this pull request Mar 14, 2024
@hug-dev
Merge pull request parallaxsecond#220 from joechrisellis/add_list_aut…
f3b12da 
…henticators

Add implementation for ListAuthenticators operation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ionut-arm ionut-arm ionut-arm approved these changes

@puiterwijk puiterwijk Awaiting requested review from puiterwijk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Superhepper @ionut-arm