Refactoring phase 1: #94
Conversation
Superhepper
force-pushed
the
refactoring_phase_1
branch
6 times, most recently
from
42715c5
to
622bb91
Compare
|
I need some reviews regarding this. It is rather massive. |
|
Will have a look today, thanks 💯 |
There was a problem hiding this comment.
Thanks for the great effort! I really like the module tree, I'm guessing you got inspiration from the spec? Looking forward to potentially splitting the Context implementation in multiple files as well.
I've left some comments below, but I don't think I reviewed everything thoroughly enough, might leave some more comments later.
Yeah I looked to the structures part of the spec and tried to basically copy it hehehe. |
Superhepper
force-pushed
the
refactoring_phase_1
branch
4 times, most recently
from
ce0dd19
to
68ac55f
Compare
Superhepper
force-pushed
the
refactoring_phase_1
branch
3 times, most recently
from
de1e340
to
bdaca0d
Compare
- Moved context to its own file. - Moved algorithm specifiers into own directory. - Created new file for algorithm structure. - Created new for structures. - Created sub dir to structures for buffer types. - Moved Digest into buffers. - Added MaxBuffer to buffers. - Added Auth to buffers. - Added Data to buffers. - Added Nonce to buffers. - Created sub dir to structures for name types. - Added Name type to names. - Made use of these new types in the places I could find they where being used. Signed-off-by: Jesper Brynolf <jesper.brynolf@gmail.com>
Superhepper
force-pushed
the
refactoring_phase_1
branch
from
bdaca0d
to
55c9067
Compare
| @@ -0,0 +1,51 @@ | |||
| use std::convert::TryFrom; | |||
There was a problem hiding this comment.
Just as a note, not necessary for this PR - we might end up moving these tests back into the files where these types are defined. For Context tests they need to be done as integration tests, but if nothing external to the test is needed then it's ok for them to be in the same file as the code they test.
| } | ||
|
|
||
| impl Nonce { | ||
| const MAX_SIZE: usize = 64; |
There was a problem hiding this comment.
I like these, very neat - can they be accessed outside this module? Or, could they be made public? I think it'd be useful for users
There was a problem hiding this comment.
Currently the cannot be acessed outside the module bit ut is no problem changing tjat.
This is part of issue #87
Moved context to its own file.
Moved algorithm specifiers into own directory.
Created new file for algorithm structure.
Created new directory for structures.
Created sub directory to structures for buffer types.
Moved Digest into buffers.
Added MaxBuffer to buffers.
Added Auth to buffers.
Added Data to buffers.
Added Nonce to buffers.
Created sub directory to structures for name types.
Added Name type to names.
Made use of these new types in the places I could find they
where being used.
Signed-off-by: Jesper Brynolf jesper.brynolf@gmail.com