Fix clippy errors #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2020
Merged
ionut-arm
approved these changes
Jul 17, 2020
|
@ionut-arm It was a relatively simple change to make :) |
This fixes the Clippy errors that map_err is more succint than or_else Err Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
|
Seems I missed one in |
Converting from a Digest to a Digest is useless, and clippy agrees on that. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
|
And next one (also fixed): clippy doesn't like useless type conversions (I guess this is a newer clippy than my version, because mine is totally fine with the code. So it may be a few more iterations). |
|
Indeed, with every iteration of the compiler some lints are added/removed to clippy (usually) and sometimes it breaks things :) We were talking about whether we should make compiler version updates manually to prevent these kind of build failures |
tgonzalezorlandoarm
pushed a commit
to tgonzalezorlandoarm/rust-tss-esapi
that referenced
this pull request
Mar 14, 2024
Add cargo clippy lints to the CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Clippy errors that map_err is more succint than or_else
Err
Signed-off-by: Patrick Uiterwijk patrick@puiterwijk.org