Add contour as dependency #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contour ingress controller is installed when enabled in values.yaml file. Default set to false. Adding contour will make local setup of rcloud easy.
akshay196-rafay
force-pushed
the
contour
branch
from
6de1b2d
to
5c9bc1f
Compare
niravparikh05
requested changes
Apr 28, 2022
niravparikh05
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contour ingress controller is installed when enabled in values.yaml
file. Default set to false. Adding contour will make local setup of
rcloud easy.
This PR has added contour CRDs to this chart, however this is workaround to HTTPProxy CR installation failure when CRDs are not present.
Solution to the #13 will also remove CRDs out of this chart.