pkg/symbol/elfutils: Fix handling of stripped Go binaries #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
force-pushed
the
fix-stripped-go-binaries
branch
from
26fa1e9
to
9f0ceef
Compare
brancz
force-pushed
the
fix-stripped-go-binaries
branch
2 times, most recently
from
fe53c78
to
0b6cb75
Compare
Go binaries that are stripped, for example built with: ``` go build -ldflags "-w -s" main.go ``` Have an empty symbol table section, which some additional build steps may strip, since it's empty. Before this patch, those Go binaries would run into an error case when attempting to load the symbol table. Since the only truly necessary section for symbolization is the `.gopclntab` section, this patch proposes to only check for this section.
brancz
force-pushed
the
fix-stripped-go-binaries
branch
from
0b6cb75
to
1034538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go binaries that are stripped, for example built with:
Have an empty symbol table section, which some additional build steps may strip, since it's empty.
Before this patch, those Go binaries would run into an error case when attempting to load the symbol table.
Since the only truly necessary section for symbolization is the
.gopclntabsection, this patch proposes to only check for this section.