fix(deploy): fix local storage

[maxbrunet]

#1989 was not enough.

Agent logs:

level=warn name=parca-agent ts=2022-11-10T22:29:57.054015758Z caller=manager.go:179 component=debuginfo buildid=4587364908de169dec62ffa538170118c1c3a078 path=/proc/6936/root/usr/lib/x86_64-linux-gnu/ld-2.31.so msg="failed to upload debug information" err="failed to upload debug information: close and receive: rpc error: code = Internal desc = failed to update metadata before uploading: failed to write metadata: mkdir /data: permission denied"

Server logs:

level=error name=parca ts=2022-11-10T22:30:00.573717776Z caller=metadata.go:211 component=debuginfo-metadata msg="failed to create metadata file" err="mkdir /data: permission denied"
level=error name=parca ts=2022-11-10T22:30:00.573778477Z caller=logger.go:38 protocol=grpc grpc.component=server grpc.service=parca.debuginfo.v1alpha1.DebugInfoService grpc.method=Upload grpc.method_type=client_stream peer.address=172.17.0.1:63240 grpc.start_time=2022-11-10T22:30:00Z grpc.code=Internal grpc.error="rpc error: code = Internal desc = failed to update metadata before uploading: failed to write metadata: mkdir /data: permission denied" grpc.time_ms=0.257 finishedcall=(MISSING)

JSON output diff:

diff --git a/before.json b/after.json
index ab798e4e..650516c3 100644
--- a/before.json
+++ b/after.json
@@ -2,7 +2,7 @@
    "parca-server-configMap": {
       "apiVersion": "v1",
       "data": {
-         "parca.yaml": "\"object_storage\":\n  \"bucket\":\n    \"config\":\n      \"directory\": \"./data\"\n    \"type\": \"FILESYSTEM\""
+         "parca.yaml": "\"object_storage\":\n  \"bucket\":\n    \"config\":\n      \"directory\": \"/var/lib/parca\"\n    \"type\": \"FILESYSTEM\""
       },
       "kind": "ConfigMap",
       "metadata": {
@@ -92,6 +92,10 @@
                         {
                            "mountPath": "/etc/parca",
                            "name": "config"
+                        },
+                        {
+                           "mountPath": "/var/lib/parca",
+                           "name": "data"
                         }
                      ]
                   }
@@ -111,6 +115,10 @@
                         "name": "parca"
                      },
                      "name": "config"
+                  },
+                  {
+                     "emptyDir": { },
+                     "name": "data"
                   }
                ]
             }

Rolled out the demo and looking good now

[kakkoyun]

LGTM. Awesome 🎉 I've been meaning to do this for some time 🔢