Fix semantics and rename http flag #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
changed the title
brancz
reviewed
Nov 16, 2022
| @@ -133,6 +135,11 @@ func Run(ctx context.Context, logger log.Logger, reg *prometheus.Registry, flags | |||
| defer closer() | |||
| } | |||
|
|
|||
| if flags.Port != "" { | |||
| level.Warn(logger).Log("msg", "flag --port is deprecated, use --http-address instead") | |||
There was a problem hiding this comment.
We broke a bunch of flags in this release I think adding one more doesn’t make a difference
There was a problem hiding this comment.
I'd done it but then reverted; it broke the snap. I think this is one of the oldest flags, so let's not ruin the backward compatibility on this one.
yomete
approved these changes
Nov 16, 2022
kakkoyun
force-pushed
the
fix_flag_semantics
branch
from
b0a1d27
to
8ba259f
Compare
metalmatze
approved these changes
Nov 17, 2022
Deprecate port flag Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
fix_flag_semantics
branch
from
acf6953
to
901df9f
Compare
kakkoyun
changed the title
kakkoyun
changed the title
kakkoyun
force-pushed
the
fix_flag_semantics
branch
from
847a695
to
901df9f
Compare
fabxc
pushed a commit
to fabxc/parca
that referenced
this pull request
Dec 5, 2022
* Fix semantics for http address flag. Deprecate port flag Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address CI issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * CI fixes Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com