Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various small arrow flamegraph perf improvements #3771

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Various small arrow flamegraph perf improvements #3771

merged 4 commits into from
Sep 6, 2023

Conversation

brancz
Copy link
Member

@brancz brancz commented Sep 6, 2023

Surprising how much more perf improvements we keep finding:

$ benchstat old.txt new.txt
name                old time/op  new time/op  delta
ArrowFlamegraph-10  1.35ms ± 1%  1.15ms ± 1%  -14.25%  (p=0.000 n=10+10)

@brancz brancz requested a review from a team as a code owner September 6, 2023 09:21
@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Sep 6, 2023

🤖 Meticulous spotted visual differences in 1 of 400 screens tested: view and approve differences detected.

Last updated for commit 71968a3. This comment will update as new commits are pushed.

Iterating over the map is a lot more expensive to do than iterating over
a slice, therefore we maintain the map for O(1) accesses, and the slice
for iterating over children.
@brancz brancz merged commit ea847c4 into main Sep 6, 2023
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants