Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unsafe in derive(IntoOwned) #614

Merged
merged 26 commits into from
Oct 25, 2023
Merged

fix: Remove unsafe in derive(IntoOwned) #614

merged 26 commits into from
Oct 25, 2023

Conversation

kdy1
Copy link
Contributor

@kdy1 kdy1 commented Oct 25, 2023

No description provided.

@kdy1 kdy1 marked this pull request as ready for review October 25, 2023 04:29
devongovett
devongovett approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still curious what the problematic case was. Maybe String? Guess I didn't realize we had any of those stored in types with into_owned. We probably didn't at the time I originally wrote that line. Sorry about that, and thanks for fixing!

@devongovett devongovett merged commit 95eb722 into parcel-bundler:master Oct 25, 2023
3 checks passed
@kdy1 kdy1 deleted the derive-unsafe branch October 25, 2023 16:53
@kdy1
Copy link
Contributor Author

kdy1 commented Oct 25, 2023

Well, I didn't try to see the problematic input. I'm also not sure why it's UB, but the transmute series is insanely unsafe.
Thank you for quickly merging and publishing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @devongovett