Fix nested async imports from a shared module #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fathyb
approved these changes
Jul 13, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
devongovett
added a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1720.
This fixes an issue where a nested async import from a common module did not work correctly. This was due to the packager checking whether the module's bundle is an immediate child. Removing this condition does not seem to cause any test failures, so I'm not sure why it was added in the first place (seems to have been there from the very beginning). Some other changes related to how the bundle tree is constructed must have made it unnecessary for other cases.