Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested async imports from a shared module #1724

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Conversation

devongovett
Copy link
Member

Fixes #1720.

This fixes an issue where a nested async import from a common module did not work correctly. This was due to the packager checking whether the module's bundle is an immediate child. Removing this condition does not seem to cause any test failures, so I'm not sure why it was added in the first place (seems to have been there from the very beginning). Some other changes related to how the bundle tree is constructed must have made it unnecessary for other cases.

@fathyb fathyb merged commit e0d8821 into master Jul 13, 2018
@fathyb fathyb deleted the fix-nested-async branch July 13, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested async imports causing incorrect build output.
2 participants