feat(autoinstall): Add disabling of autoinstall globally via environm… #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cacheflow
force-pushed
the
disable-autoinstall-globally-via-env-var
branch
from
b3daf7f
to
644170a
Compare
devongovett
reviewed
Oct 17, 2018
cacheflow
force-pushed
the
disable-autoinstall-globally-via-env-var
branch
2 times, most recently
from
caa6a36
to
10cfca9
Compare
devongovett
reviewed
Oct 18, 2018
| const autoInstall = | ||
| typeof options.autoinstall === 'boolean' | ||
| ? options.autoinstall | ||
| : typeof process.env.PARCEL_AUTOINSTALL === 'boolean' |
There was a problem hiding this comment.
does that actually get converted to a boolean if you provide this environment variable from a terminal?
There was a problem hiding this comment.
It does not, so I've updated the check.
cacheflow
force-pushed
the
disable-autoinstall-globally-via-env-var
branch
3 times, most recently
from
856764c
to
47b998f
Compare
…ment variable -Closes parcel-bundler#2130.
devongovett
force-pushed
the
disable-autoinstall-globally-via-env-var
branch
from
47b998f
to
ddb8234
Compare
devongovett
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
-Allow disabling of autoinstall via a environment variable named PARCEL_AUTOINSTALL.
✔️ PR Todo
Feature Request: #2081