New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Buffer.from instead of new Buffer() #2512

Merged

devongovett merged 1 commit into master from buffer-from

Jan 7, 2019

Member

mischnic commented Jan 5, 2019

↪️ Pull Request

Removes some warnings when running the tests
Based on https://nodejs.org/en/docs/guides/buffer-constructor-deprecation/#variant-1

💻 Examples

✔️ PR Todo

Added/updated unit tests for this change
Filled out test instructions (In case there aren't any unit tests)
Included links to related issues/PRs

Member Author

mischnic commented Jan 5, 2019

Failing tests likely caused by #2506


          Use Buffer.from

ca537c0

mischnic force-pushed the buffer-from branch from 1837dc2 to ca537c0 Compare

January 5, 2019 23:28

devongovett approved these changes

View reviewed changes

devongovett merged commit 6e1bc68 into master

devongovett deleted the buffer-from branch

January 7, 2019 20:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet