Avoid crash when "--max-old-space-size" is present #5017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This is a fix for issue #4795. Parcel 2 runs out of memory building large code bases. Normally you can pass the
--max-old-space-size=...
flag to node to increase the memory ceiling for node programs, but this doesn't work with Parcel because passing this flag causes Parcel to crash.💻 Examples
The crash looks like this:
This change prevents the crash.
🚨 Test instructions
I ran this command inside the Parcel repo to test this change:
This command fails without my change and passes with my change.
✔️ PR Todo