Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add invalidations for transformation cache hits #6072

Merged
merged 3 commits into from
Apr 3, 2021
Merged

Re-add invalidations for transformation cache hits #6072

merged 3 commits into from
Apr 3, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Apr 1, 2021 •
edited
Loading

Resaving an included file without changing the content would make Parcel forget about the included file.

The invalidations for an asset request are always cleared before calling out to Transformation, but then a hit in transformation cache wouldn't readd them to the invalidations (and since the transformer didn't run, it's also not in asset.invalidations).

This might be causing #5927 as well

Related to https://github.com/tailwindlabs/tailwindcss-jit/issues/129#issuecomment-812036137 / tailwindlabs/tailwindcss#3951

@height
Copy link

height bot commented Apr 1, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 1, 2021 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 7.56s -44.00ms
Cached 422.00ms -28.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 431.00ms -62.00ms 🚀
dist/legacy/index.76ce4b0c.js 1.12kb +0.00b 493.00ms -430.00ms 🚀
dist/legacy/index.html 701.00b +0.00b 491.00ms -429.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 57.00ms +3.00ms ⚠️
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 56.00ms -20.00ms 🚀
dist/modern/index.b43fcc94.js 1.12kb +0.00b 75.00ms -4.00ms 🚀
dist/modern/index.html 701.00b +0.00b 57.00ms -22.00ms 🚀
dist/modern/index.0bc656bc.css 77.00b +0.00b 58.00ms -21.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 21.20s -299.00ms
Cached 677.00ms +26.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.0a19c7e4.js 4.24kb +0.00b 800.00ms -65.00ms 🚀
dist/UserProfile.b2960402.js 1.78kb +0.00b 800.00ms -65.00ms 🚀
dist/NotFound.f3269ae7.js 542.00b +0.00b 295.00ms +28.00ms ⚠️
dist/logo.24c8bf9e.png 274.00b +0.00b 96.00ms -5.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 477.81kb +0.00b 140.00ms +27.00ms ⚠️
dist/PermalinkedComment.0a19c7e4.js 4.24kb +0.00b 140.00ms +27.00ms ⚠️
dist/UserProfile.b2960402.js 1.78kb +0.00b 140.00ms +27.00ms ⚠️
dist/NotFound.f3269ae7.js 542.00b +0.00b 87.00ms +5.00ms ⚠️
dist/logo.24c8bf9e.png 274.00b +0.00b 87.00ms +5.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 2.55m +10.34s ⚠️
Cached 3.30s +525.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/index.e48a72e5.js 2.46mb +6.00b ⚠️ 1.03m +3.43s ⚠️
dist/editorView.ea13a2b7.js 588.08kb +0.00b 52.92s +2.71s ⚠️
dist/popup.119ff481.js 171.12kb +0.00b 16.60s +1.96s ⚠️
dist/EmojiPickerComponent.c4358f76.js 139.84kb +0.00b 12.15s +3.23s ⚠️
dist/Toolbar.0c83bb49.js 100.68kb +0.00b 16.47s +2.01s ⚠️
dist/media-viewer.ebcb5e1e.js 73.43kb +0.00b 12.54s +2.46s ⚠️
dist/card.df70c9b7.js 54.67kb +0.00b 10.56s +2.36s ⚠️
dist/card.1d931b4c.js 52.43kb +0.00b 13.49s +1.63s ⚠️
dist/Modal.558fb5db.js 39.59kb +0.00b 3.96s +430.00ms ⚠️
dist/component.ad27194c.js 31.05kb +0.00b 4.12s +579.00ms ⚠️
dist/esm.e3419f0a.js 27.83kb +0.00b 10.49s +3.91s ⚠️
dist/component.f25dcadb.js 22.80kb +0.00b 3.95s +495.00ms ⚠️
dist/DatePicker.faca45d0.js 21.38kb +0.00b 9.69s +1.25s ⚠️
dist/smartMediaEditor.21f91ed8.js 16.96kb +0.00b 16.36s +2.02s ⚠️
dist/js.8167e2d5.js 16.55kb +0.00b 3.95s +495.00ms ⚠️
dist/dropzone.3ae9a030.js 16.15kb +0.00b 16.41s +2.05s ⚠️
dist/ui.15dd7acd.js 14.30kb +0.00b 10.49s +2.30s ⚠️
dist/component.677fad45.js 6.23kb +0.00b 4.39s +653.00ms ⚠️
dist/card.3a4028bd.js 5.74kb +0.00b 12.26s +4.06s ⚠️
dist/media-viewer.f15e56f4.js 4.01kb +0.00b 11.51s +1.44s ⚠️
dist/png-chunks-extract.608f438d.js 3.56kb +0.00b 3.95s +495.00ms ⚠️
dist/dropzone.d1e8004d.js 3.46kb +0.00b 11.81s +1.47s ⚠️
dist/index.ece3a13e.css 3.46kb +0.00b 17.09s +888.00ms ⚠️
dist/Modal.08282ab6.js 3.23kb +0.00b 1.04s +143.00ms ⚠️
dist/clipboard.6a6e5fbd.js 3.00kb +0.00b 16.46s +5.29s ⚠️
dist/16.b6ca7fd0.js 2.50kb +0.00b 1.04s +143.00ms ⚠️
dist/ResourcedEmojiComponent.5046c0ff.js 2.19kb +0.00b 7.41s -1.21s 🚀
dist/card.2888338b.js 2.15kb +0.00b 11.62s +1.54s ⚠️
dist/date.a69000aa.js 1.97kb +0.00b 4.92s +860.00ms ⚠️
dist/images.ece03ae5.js 1.91kb +0.00b 4.63s +479.00ms ⚠️
dist/feedback.facaac2e.js 1.87kb +0.00b 5.53s +955.00ms ⚠️
dist/16.a9ea9b41.js 1.86kb +0.00b 4.35s +491.00ms ⚠️
dist/browser.8883c452.js 1.85kb +0.00b 13.45s +2.27s ⚠️
dist/16.89d45d15.js 1.80kb +0.00b 4.13s +463.00ms ⚠️
dist/workerHasher.31326e89.js 1.77kb +0.00b 9.69s +3.12s ⚠️
dist/workerHasher.d607e0b8.js 1.77kb +0.00b 13.51s -1.03s 🚀
dist/list-number.d4568b49.js 1.69kb +0.00b 4.74s +591.00ms ⚠️
dist/status.6595d133.js 1.69kb +0.00b 4.89s +479.00ms ⚠️
dist/code.efde0f48.js 1.61kb +0.00b 4.53s +496.00ms ⚠️
dist/link.5be155be.js 1.54kb +0.00b 4.74s +591.00ms ⚠️
dist/heading6.5a6082c8.js 1.53kb +0.00b 4.99s +434.00ms ⚠️
dist/heading3.1c92891c.js 1.52kb +0.00b 4.99s +434.00ms ⚠️
dist/16.07ccad90.js 1.51kb +0.00b 4.67s +659.00ms ⚠️
dist/16.00f25203.js 1.47kb +0.00b 4.13s +463.00ms ⚠️
dist/16.02056ae6.js 1.47kb +0.00b 4.15s +464.00ms ⚠️
dist/16.b7da7bde.js 1.45kb +0.00b 1.04s +143.00ms ⚠️
dist/16.00100306.js 1.44kb +0.00b 4.53s +498.00ms ⚠️
dist/16.bdd61d2d.js 1.41kb +0.00b 4.53s +354.00ms ⚠️
dist/heading5.88bc6249.js 1.41kb +0.00b 4.99s +434.00ms ⚠️
dist/expand.4a483eb0.js 1.39kb +0.00b 9.68s +1.27s ⚠️
dist/16.fa5f411c.js 1.36kb +0.00b 4.35s +491.00ms ⚠️
dist/16.2a21d3f4.js 1.34kb +0.00b 1.04s +143.00ms ⚠️
dist/heading2.22de70fe.js 1.34kb +0.00b 4.99s +569.00ms ⚠️
dist/16.d10db5a3.js 1.32kb +0.00b 4.35s +497.00ms ⚠️
dist/16.c9db7e6b.js 1.32kb +0.00b 4.53s +496.00ms ⚠️
dist/mention.c44b48ed.js 1.30kb +0.00b 4.74s +472.00ms ⚠️
dist/heading4.a2524c70.js 1.29kb +0.00b 4.99s +434.00ms ⚠️
dist/Modal.44e980e0.js 1.29kb +0.00b 3.95s +495.00ms ⚠️
dist/layout.81f2196c.js 1.28kb +0.00b 4.63s +479.00ms ⚠️
dist/16.9e97e787.js 1.28kb +0.00b 1.04s +143.00ms ⚠️
dist/16.acff901d.js 1.27kb +0.00b 4.35s +491.00ms ⚠️
dist/component.233c7a65.js 1.26kb +0.00b 4.12s +581.00ms ⚠️
dist/16.015dfb9d.js 1.26kb +0.00b 4.15s +475.00ms ⚠️
dist/16.828b958e.js 1.26kb +0.00b 4.67s +659.00ms ⚠️
dist/16.b9b1643b.js 1.26kb +0.00b 4.67s +659.00ms ⚠️
dist/16.ec84a250.js 1.26kb +0.00b 4.13s +463.00ms ⚠️
dist/quote.b6d8bffb.js 1.25kb +0.00b 4.89s +479.00ms ⚠️
dist/media-card-analytics-error-boundary.ff0177b3.js 1.25kb +0.00b 10.74s +2.54s ⚠️
dist/action.01ec8983.js 1.24kb +0.00b 4.53s +496.00ms ⚠️
dist/16.458399e0.js 1.23kb +0.00b 4.12s +581.00ms ⚠️
dist/panel-warning.b5f3360d.js 1.22kb +0.00b 5.27s +983.00ms ⚠️
dist/list.2dfe3f18.js 1.19kb +0.00b 4.74s +577.00ms ⚠️
dist/heading1.cc82b077.js 1.19kb +0.00b 4.89s +479.00ms ⚠️
dist/16.90358f40.js 1.18kb +0.00b 4.36s +495.00ms ⚠️
dist/panel-error.7454ebc0.js 1.12kb +0.00b 4.74s +472.00ms ⚠️
dist/panel.fc70749c.js 1.11kb +0.00b 4.89s -478.00ms 🚀
dist/table.77df779b.js 1.10kb +0.00b 4.89s +479.00ms ⚠️
dist/panel-success.d5752da0.js 1.06kb +0.00b 5.27s +994.00ms ⚠️
dist/panel-note.6a71a1f2.js 1.05kb +0.00b 5.27s +994.00ms ⚠️
dist/media-picker-analytics-error-boundary.49b32f4d.js 1023.00b +0.00b 16.36s +5.75s ⚠️
dist/media-card-analytics-error-boundary.9a500f44.js 1019.00b +0.00b 10.54s +2.35s ⚠️
dist/media-card-analytics-error-boundary.b884d580.js 1019.00b +0.00b 13.50s +2.32s ⚠️
dist/media-viewer-analytics-error-boundary.83da5db2.js 1015.00b +0.00b 12.58s +2.50s ⚠️
dist/index.html 119.00b +0.00b 3.09s +450.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.e48a72e5.js 2.46mb +0.00b 621.00ms +96.00ms ⚠️
dist/pdfRenderer.f5a3f4a7.js 1.11mb +0.00b 675.00ms +99.00ms ⚠️
dist/editorView.ea13a2b7.js 588.08kb +0.00b 694.00ms +97.00ms ⚠️
dist/popup.119ff481.js 171.12kb +0.00b 680.00ms +89.00ms ⚠️
dist/EmojiPickerComponent.c4358f76.js 139.84kb +0.00b 652.00ms +88.00ms ⚠️
dist/Toolbar.0c83bb49.js 100.68kb +0.00b 697.00ms +100.00ms ⚠️
dist/media-viewer.ebcb5e1e.js 73.43kb +0.00b 675.00ms +99.00ms ⚠️
dist/card.df70c9b7.js 54.67kb +0.00b 656.00ms +92.00ms ⚠️
dist/card.1d931b4c.js 52.43kb +0.00b 694.00ms +104.00ms ⚠️
dist/Modal.558fb5db.js 39.59kb +0.00b 620.00ms +91.00ms ⚠️
dist/esm.e3419f0a.js 27.83kb +0.00b 654.00ms +102.00ms ⚠️
dist/component.f25dcadb.js 22.80kb +0.00b 547.00ms +48.00ms ⚠️
dist/DatePicker.faca45d0.js 21.38kb +0.00b 627.00ms +63.00ms ⚠️
dist/smartMediaEditor.21f91ed8.js 16.96kb +0.00b 694.00ms +97.00ms ⚠️
dist/js.8167e2d5.js 16.55kb +0.00b 547.00ms +48.00ms ⚠️
dist/dropzone.3ae9a030.js 16.15kb +0.00b 694.00ms +110.00ms ⚠️
dist/ui.15dd7acd.js 14.30kb +0.00b 656.00ms +93.00ms ⚠️
dist/workerHasher.bc6346e1.js 11.90kb +0.00b 654.00ms +99.00ms ⚠️
dist/component.677fad45.js 6.23kb +0.00b 547.00ms +48.00ms ⚠️
dist/card.3a4028bd.js 5.74kb +0.00b 675.00ms +99.00ms ⚠️
dist/media-viewer.f15e56f4.js 4.01kb +0.00b 676.00ms +99.00ms ⚠️
dist/EmojiPickerComponent.4991ddd4.js 3.68kb +0.00b 656.00ms +101.00ms ⚠️
dist/png-chunks-extract.608f438d.js 3.56kb +0.00b 547.00ms +48.00ms ⚠️
dist/dropzone.d1e8004d.js 3.46kb +0.00b 680.00ms +89.00ms ⚠️
dist/index.ece3a13e.css 3.46kb +0.00b 700.00ms +105.00ms ⚠️
dist/Modal.08282ab6.js 3.23kb +0.00b 620.00ms +131.00ms ⚠️
dist/clipboard.6a6e5fbd.js 3.00kb +0.00b 694.00ms +104.00ms ⚠️
dist/16.b6ca7fd0.js 2.50kb +0.00b 533.00ms +44.00ms ⚠️
dist/ResourcedEmojiComponent.5046c0ff.js 2.19kb +0.00b 656.00ms +93.00ms ⚠️
dist/card.2888338b.js 2.15kb +0.00b 680.00ms +89.00ms ⚠️
dist/date.a69000aa.js 1.97kb +0.00b 591.00ms +62.00ms ⚠️
dist/images.ece03ae5.js 1.91kb +0.00b 600.00ms +70.00ms ⚠️
dist/feedback.facaac2e.js 1.87kb +0.00b 627.00ms +63.00ms ⚠️
dist/16.a9ea9b41.js 1.86kb +0.00b 572.00ms +57.00ms ⚠️
dist/browser.8883c452.js 1.85kb +0.00b 694.00ms +104.00ms ⚠️
dist/16.89d45d15.js 1.80kb +0.00b 558.00ms +51.00ms ⚠️
dist/workerHasher.31326e89.js 1.77kb +0.00b 654.00ms +99.00ms ⚠️
dist/workerHasher.d607e0b8.js 1.77kb +0.00b 694.00ms +97.00ms ⚠️
dist/list-number.d4568b49.js 1.69kb +0.00b 608.00ms +75.00ms ⚠️
dist/status.6595d133.js 1.69kb +0.00b 617.00ms +80.00ms ⚠️
dist/code.efde0f48.js 1.61kb +0.00b 591.00ms +62.00ms ⚠️
dist/link.5be155be.js 1.54kb +0.00b 600.00ms +68.00ms ⚠️
dist/heading6.5a6082c8.js 1.53kb +0.00b 627.00ms +80.00ms ⚠️
dist/heading3.1c92891c.js 1.52kb +0.00b 626.00ms +79.00ms ⚠️
dist/16.07ccad90.js 1.51kb +0.00b 571.00ms +56.00ms ⚠️
dist/16.00f25203.js 1.47kb +0.00b 558.00ms +51.00ms ⚠️
dist/16.02056ae6.js 1.47kb +0.00b 558.00ms +51.00ms ⚠️
dist/emoji.b5624cf5.js 1.46kb +0.00b 599.00ms +70.00ms ⚠️
dist/16.b7da7bde.js 1.45kb +0.00b 533.00ms +44.00ms ⚠️
dist/16.00100306.js 1.44kb +0.00b 581.00ms +58.00ms ⚠️
dist/16.bdd61d2d.js 1.41kb +0.00b 581.00ms +58.00ms ⚠️
dist/heading5.88bc6249.js 1.41kb +0.00b 627.00ms +80.00ms ⚠️
dist/expand.4a483eb0.js 1.39kb +0.00b 627.00ms +63.00ms ⚠️
dist/16.fa5f411c.js 1.36kb +0.00b 581.00ms +58.00ms ⚠️
dist/16.2a21d3f4.js 1.34kb +0.00b 533.00ms +44.00ms ⚠️
dist/heading2.22de70fe.js 1.34kb +0.00b 626.00ms +62.00ms ⚠️
dist/16.d10db5a3.js 1.32kb +0.00b 581.00ms +58.00ms ⚠️
dist/16.c9db7e6b.js 1.32kb +0.00b 591.00ms +62.00ms ⚠️
dist/mention.c44b48ed.js 1.30kb +0.00b 608.00ms +75.00ms ⚠️
dist/heading4.a2524c70.js 1.29kb +0.00b 627.00ms +80.00ms ⚠️
dist/Modal.44e980e0.js 1.29kb +0.00b 547.00ms +48.00ms ⚠️
dist/layout.81f2196c.js 1.28kb +0.00b 600.00ms +68.00ms ⚠️
dist/16.9e97e787.js 1.28kb +0.00b 533.00ms +44.00ms ⚠️
dist/16.acff901d.js 1.27kb +0.00b 571.00ms +56.00ms ⚠️
dist/component.233c7a65.js 1.26kb +0.00b 621.00ms +96.00ms ⚠️
dist/16.015dfb9d.js 1.26kb +0.00b 558.00ms +51.00ms ⚠️
dist/16.828b958e.js 1.26kb +0.00b 571.00ms +56.00ms ⚠️
dist/16.b9b1643b.js 1.26kb +0.00b 571.00ms +56.00ms ⚠️
dist/16.ec84a250.js 1.26kb +0.00b 558.00ms +51.00ms ⚠️
dist/divider.ed7ccd2e.js 1.26kb +0.00b 599.00ms +70.00ms ⚠️
dist/quote.b6d8bffb.js 1.25kb +0.00b 617.00ms +80.00ms ⚠️
dist/media-card-analytics-error-boundary.ff0177b3.js 1.25kb +0.00b 675.00ms +101.00ms ⚠️
dist/action.01ec8983.js 1.24kb +0.00b 591.00ms +62.00ms ⚠️
dist/16.458399e0.js 1.23kb +0.00b 620.00ms +95.00ms ⚠️
dist/decision.c48f9f1e.js 1.22kb +0.00b 591.00ms +62.00ms ⚠️
dist/panel-warning.b5f3360d.js 1.22kb +0.00b 617.00ms +81.00ms ⚠️
dist/list.2dfe3f18.js 1.19kb +0.00b 608.00ms +75.00ms ⚠️
dist/heading1.cc82b077.js 1.19kb +0.00b 626.00ms +88.00ms ⚠️
dist/16.90358f40.js 1.18kb +0.00b 581.00ms +58.00ms ⚠️
dist/panel-error.7454ebc0.js 1.12kb +0.00b 608.00ms +72.00ms ⚠️
dist/panel.fc70749c.js 1.11kb +0.00b 617.00ms +74.00ms ⚠️
dist/table.77df779b.js 1.10kb +0.00b 626.00ms +89.00ms ⚠️
dist/panel-success.d5752da0.js 1.06kb +0.00b 617.00ms +81.00ms ⚠️
dist/panel-note.6a71a1f2.js 1.05kb +0.00b 609.00ms +73.00ms ⚠️
dist/media-picker-analytics-error-boundary.49b32f4d.js 1023.00b +0.00b 692.00ms +101.00ms ⚠️
dist/media-card-analytics-error-boundary.9a500f44.js 1019.00b +0.00b 656.00ms +92.00ms ⚠️
dist/media-card-analytics-error-boundary.b884d580.js 1019.00b +0.00b 694.00ms +104.00ms ⚠️
dist/media-viewer-analytics-error-boundary.83da5db2.js 1015.00b +0.00b 680.00ms +89.00ms ⚠️
dist/simpleHasher.79137cb4.js 767.00b +0.00b 654.00ms +99.00ms ⚠️
dist/simpleHasher.2c5206fd.js 767.00b +0.00b 694.00ms +97.00ms ⚠️
dist/index.html 119.00b +0.00b 534.00ms +82.00ms ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 20.34s -797.00ms
Cached 606.00ms -84.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.60kb +0.00b 7.09s -596.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.60kb +0.00b 109.00ms -19.00ms 🚀

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 8227604 into v2 Apr 3, 2021
@mischnic mischnic deleted the transformer-cache-invalidations branch April 3, 2021 09:42
This was referenced Apr 5, 2021
Open
Open
@cmditch cmditch mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @parcel-benchmark @devongovett