-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change edge types to numbers #6126
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
04a89fe
change edgetypes to numbers
thebriando 1139fc6
Merge remote-tracking branch 'origin/v2' into bdo/number-edgetypes
thebriando c09a85e
clean up comments
thebriando 4fd4898
fix edge colors in graphviz
thebriando bb58ee8
camelCase edge type objects
thebriando 1a07b1e
add NullEdgeType to generic in Array edge types
thebriando 99c1761
Merge branch 'v2' into bdo/number-edgetypes
thebriando b453252
Merge remote-tracking branch 'origin/v2' into bdo/number-edgetypes
thebriando 65bd2df
Merge branch 'v2' of github.com:parcel-bundler/parcel into bdo/number…
devongovett 8657593
Merge remote-tracking branch 'origin/v2' into bdo/number-edgetypes
thebriando e85fc92
Change NullEdgeType to 1
thebriando 0b0a475
Merge branch 'v2' into bdo/number-edgetypes
lettertwo 8471d60
Merge remote-tracking branch 'origin/v2' into bdo/number-edgetypes
thebriando 414a3f2
Fix colors in graphviz
thebriando 2951a01
Fix types
thebriando 4b6c509
Merge remote-tracking branch 'origin/v2' into bdo/number-edgetypes
thebriando File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should not support the null edge type at all, and just have users/extenders always specify the types of edges the way they do nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @devongovett @mischnic