Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swc wasm: convert HashMap to objects directly #6413

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Jun 4, 2021

Leverage RReverser/serde-wasm-bindgen#12 to avoid additional wrapper code

@height
Copy link

height bot commented Jun 4, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.31s -1.00ms
Cached 335.00ms -4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 40.00ms -5.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 61.00ms +18.00ms ⚠️
dist/legacy/index.782bc049.js 2.00kb +0.00b 62.00ms -4.00ms 🚀
dist/modern/index.html 701.00b +0.00b 61.00ms -5.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 8.68s -25.00ms
Cached 566.00ms -11.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 491.05kb +0.00b 80.00ms +10.00ms ⚠️
dist/PermalinkedComment.4bc80878.js 4.19kb +0.00b 80.00ms +10.00ms ⚠️
dist/UserProfile.f83d252c.js 1.56kb +0.00b 80.00ms +10.00ms ⚠️
dist/NotFound.c41ac89d.js 417.00b +0.00b 80.00ms +10.00ms ⚠️
dist/logo.1e014c76.png 274.00b +0.00b 46.00ms +3.00ms ⚠️

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 6.11s +136.00ms
Cached 490.00ms +2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 0367840 into v2 Jun 5, 2021
@mischnic mischnic deleted the js-swc-map-object branch June 5, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants