Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of hoisted variable declarations #7053

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

devongovett
Copy link
Member

No description provided.

@height
Copy link

height bot commented Oct 11, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 11, 2021

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.94s +18.00ms
Cached 447.00ms +22.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 654.00ms -119.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 655.00ms -119.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 655.00ms -119.00ms 🚀
dist/legacy/index.96016b08.js 1.59kb +0.00b 1.01s -118.00ms 🚀
dist/legacy/index.85a438f5.js 1.20kb +0.00b 1.01s -118.00ms 🚀
dist/modern/index.6be20f01.js 1.13kb +0.00b 1.00s -119.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 1.30s -85.00ms 🚀
dist/modern/index.html 749.00b +0.00b 1.30s -85.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 695.00ms -202.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 697.00ms -201.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 696.00ms -200.00ms 🚀
dist/legacy/index.786e03c3.js 1.59kb +0.00b 933.00ms -70.00ms 🚀
dist/legacy/index.8aaa89c9.js 1.20kb +0.00b 933.00ms -70.00ms 🚀
dist/modern/index.7b46005f.js 1.13kb +0.00b 932.00ms -70.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 1.10s -97.00ms 🚀
dist/modern/index.html 749.00b +0.00b 1.10s -95.00ms 🚀
dist/legacy/index.c1bc86aa.css 94.00b +0.00b 1.35s -86.00ms 🚀
dist/modern/index.57a95cbe.css 94.00b +0.00b 1.35s -87.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 12.91s -651.00ms 🚀
Cached 612.00ms -65.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 8.90s -402.00ms
Cached 578.00ms +63.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants