-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative path for bundle labels in bundle analysis #7737
Conversation
There is no value in providing the full path as the bundle label, and it can get quite long in CI/CD Changing to relativePath will make the label shorter and easier to read
|
packages/reporters/bundle-analyzer/src/BundleAnalyzerReporter.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com>
@mischnic I would also like to enable bundle analysis on the modules only: (Right now it has both module and no-module, so everything is replicated) Any quick pointers for how I would make it happen? Thanks! i.e. where can I place the config for that behavior assuming that not everyone wants it. cc @devongovett |
I guess the hard part for that is determining which bundle is the nomodule half of a nomodule/module pair. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only problem I can see with this change is projects including files from outside the project path, then you'd get paths like ../../foo
. But this situation isn't really supported anyway because these files aren not watched anyway
* upstream/v2: Upgrade Flow to 0.174.1 (#7849) v2.4.0 v2.4.0 changelog Bump Parcel CSS Dynamic imports priority fix closes #6980 (#7061) fix(transformers): errors.map is not a function (#7672) Make NodeResolver check realpath before resolving with `source` entry (#7846) docs: fix wrong location documents (#7689) Fix: escape double quote of url value in CSS `url()` (#7718) Update @parcel/css and add diagnostic for url dependencies in custom properties (#7845) Use relative path for bundle labels in bundle analysis (#7737) Allow use react-jsx transform in React 16.14.0 (#7728) Move to @parcel/css by default (#7821) Feature: pick PORT number also from .env file (#7819) Enable parsing static initialization blocks (#7839) Bump swc and prevent pure comment removal (#7833) Bump swc (#7777) Human readable file size in bundle analyzer report (#7766) Improve emoji support detection (#7775)
There is no value in providing the full path as the bundle label, and it can get quite long in CI/CD
Changing to relativePath will make the label shorter and easier to read
↪️ Pull Request
💻 Examples
🚨 Test instructions
✔️ PR Todo