ScopeHoistingPackager: Wrap assets when any ancestor is wrapped #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbinnssmith
force-pushed
the
wbinnssmith/multiple-ancestors-wrap
branch
from
53f296a
to
dd7a39b
Compare
wbinnssmith
force-pushed
the
wbinnssmith/multiple-ancestors-wrap
branch
from
dd7a39b
to
344941e
Compare
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
added 5 commits
April 5, 2022 16:28
AGawrys
approved these changes
Apr 11, 2022
lettertwo
approved these changes
Apr 11, 2022
thebriando
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on DFS context is insufficient as it only considers the first ancestor's wrapped state. This performs a dfs downward from each initially wrapped root asset, skipping children as soon as it encounters a currently wrapped asset, ensuring that we don't visit any unnecessary assets further.
Test Plan: Added an integration test.
yarn test