Catch uncaught promise build abort race #8600
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a build is aborted while writing bundles, the process could crash. This happened because we didn't immediately await a promise, so if the build was aborted between when the promise was created and when it was awaited, node would trigger an unhandled promise rejection. This adds an empty
.catch
to prevent that. The error should still be picked up when the promise is awaited later.Closes #8548