Fix CSS order when merging type change bundles #8766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Jan 14, 2023
|
|
||
| let css = await outputFS.readFile(path.join(distDir, 'index.css'), 'utf8'); | ||
| assert.ok(css.indexOf('.c {') < css.indexOf('.local {')); | ||
| assert.ok(css.indexOf('.local {') < css.indexOf('.index {')); |
There was a problem hiding this comment.
previous order was c, index, local. now order is c, local, index.
devongovett
commented
Jan 14, 2023
| @@ -353,6 +353,7 @@ describe('css modules', () => { | |||
| assert(css.includes('height: 100px;')); | |||
| assert(css.includes('height: 300px;')); | |||
| assert(css.indexOf('_test') < css.indexOf('_intermediate')); | |||
| assert(css.indexOf('_intermediate') < css.indexOf('_composes5')); | |||
There was a problem hiding this comment.
previously composes5 was first, now it's last as expected.
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
AGawrys
approved these changes
Jan 17, 2023
marcins
pushed a commit
to marcins/parcel
that referenced
this pull request
Jul 14, 2023
* upstream/v2: (33 commits) v2.8.3 Changelog for v2.8.3 Address bug by updating an asset reference and merge conditions (parcel-bundler#8762) Fix CSS order when merging type change bundles (parcel-bundler#8766) fixing failing build for contributors on Linux using Node 18 (parcel-bundler#8763) Extension: Importers View and separate LSP protocol package (parcel-bundler#8747) Bump swc to fix sourcemaps with Windows line endings (parcel-bundler#8756) Apply HMR updates in topological order (parcel-bundler#8752) Make extension packaging work (parcel-bundler#8730) Typed api.storeResult (parcel-bundler#8732) Refactor LSP to use vscode-jsonrpc (parcel-bundler#8728) Bump swc (parcel-bundler#8742) Recursively check reachability when removing asset graphs from bundles in deduplication (parcel-bundler#6004) Fix tsc sourcemaps metadata (parcel-bundler#8734) Assigning to `this` in CommonJS (parcel-bundler#8737) Don't retarget dependencies if a symbol is imported multiple times with different local names (parcel-bundler#8738) Add a note about using flow in CONTRIBUTING.md (parcel-bundler#8731) filter out title execArgv to workers (parcel-bundler#8719) Document more of the BundleGraph class (parcel-bundler#8711) Fixed the hmr connection with host 0.0.0.0 (parcel-bundler#7357) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when merging type change bundles that could result in CSS being bundled in the wrong order. We need to merge the contents of later bundles into earlier bundles, not the other way around.
I think this was potentially a workaround for an issue with CSS modules where there was no dependency in the CSS asset to
composesdeps, only in the JS, which left the graph in a weird state. I don't remember why that was the case, but now the dependency is in both places which fixes the problem. The test output was also slightly incorrect before anyway.