[WIP] Fix HMR failure with js error on load

[mischnic]

global.require isn't defined if a childBundle called by newRequire throws an error.
This causes an error on HMR update.

More details in #879 (comment)

fixes #879

[mischnic]

Tests fail because errors from require don't bubble up anymore.

  try {
    // We expect browser-resolve to replace fs with an empty module, so readFileSync will be undefined
    return require('fs').readFileSync(__dirname + '/package.json')
  }
  catch(_) {
    return 'test-pkg-ignore-fs-ok'
  }

Would it be better to instead change prelude.js to something like this: (this makes sure require isn't undefined)?

require = function (...){...};
require({1:[], .....});

(Maybe this doesn't work at all because of how prelude.js works)

[wzrdtales]

loocking forward to this

[wzrdtales]

@mischnic localRequire needs the same fix, since it bares the same problem

[mischnic]

@devongovett Could you take a look at how to fix this correctly?

[FDiskas]

📨 waiting for the fix also

[devongovett]

Due to move to monorepo which rewrote the git history, this PR was automatically closed. Please open a new PR against master with your changes. You can do a diff against the 1.x branch to see them. Sorry about that!