Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some dependencies with "breaking" changes in patch versions #9017

Merged
merged 4 commits into from
May 23, 2023

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented May 16, 2023

I copied some changes from #8631 that aren't related to undeclared dependencies (and caused the tests to fail once some deps were bumped in the lockfile)

Both of these happened in a patch version (that is covered by our dependency ranges):

  • fastest-levenshtein added __esModule: true, so import levenshtein from "..." didn't work anymore.
  • xmldom now correctly updates element.parentNode after removing the element:
element.parentNode.removeChild(element);
element.parentNode.appendChild(...); // parentNode is null now

And for empty documents, parsed.documentElement is null

@mischnic mischnic changed the title Bump some dependencies that with "breaking" changes in patch version Bump some dependencies with "breaking" changes in patch version May 16, 2023
@mischnic mischnic changed the title Bump some dependencies with "breaking" changes in patch version Bump some dependencies with "breaking" changes in patch version s May 16, 2023
@mischnic mischnic changed the title Bump some dependencies with "breaking" changes in patch version s Bump some dependencies with "breaking" changes in patch versions May 16, 2023
@mischnic mischnic changed the title Bump some dependencies with "breaking" changes in patch versions Update some dependency ranges with "breaking" changes in patch versions May 16, 2023
@mischnic mischnic requested a review from devongovett May 16, 2023 14:41
@mischnic mischnic changed the title Update some dependency ranges with "breaking" changes in patch versions Bump some dependencies with "breaking" changes in patch versions May 23, 2023
@mischnic mischnic merged commit 3ad4351 into v2 May 23, 2023
@mischnic mischnic deleted the bump-deps branch May 23, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants