Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fix HMR on .localhost domains (e.g. https://project.localhost).
Fixes #7490
💻 Examples
Before, it was trying to connect to the HMR websocket over the
ws://
protocol, even though https://project.localhost is a secure domain. Now, it correctly uses thewss://
protocol.🚨 Test instructions
Set up a project on https://project.localhost. An easy way is with caddy.
Verify that the HMR websocket connection is made to wss://project.localhost/, not ws://project.localhost/
✔️ PR Todo