Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In db/common.c
schema_create
andschema_delete
are called, passing an error, while in db/schema.c there are notes that the user should not pass an error to these functions.Currently, it seems to work (maybe out of luck) when running SQLite server on the same host as the benchmark.
However, when MariaDB is used (with Singularity), it fails.
I assume this may be because the MariaDB server tries to access the address passed in the error pointer in its own address space. After all, the MariaDB server should not be able to access anything outside the container, right?
Passing NULL instead of the error pointer, seems to fix the problem.