Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DB benchmark for MySQL/MariaDB #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiraduwe
Copy link
Member

In db/common.c schema_create and schema_deleteare called, passing an error, while in db/schema.c there are notes that the user should not pass an error to these functions.

Currently, it seems to work (maybe out of luck) when running SQLite server on the same host as the benchmark.
However, when MariaDB is used (with Singularity), it fails.

/db/entry/insert:                     **
JULEA:ERROR:../benchmark/db/common.c:131:_benchmark_db_prepare_scheme: 'ret' should be TRUE
Bail out! JULEA:ERROR:../benchmark/db/common.c:131:_benchmark_db_prepare_scheme: 'ret' should be TRUE

I assume this may be because the MariaDB server tries to access the address passed in the error pointer in its own address space. After all, the MariaDB server should not be able to access anything outside the container, right?

Passing NULL instead of the error pointer, seems to fix the problem.

@michaelkuhn michaelkuhn self-assigned this Jul 24, 2022
@michaelkuhn
Copy link
Member

This seems to be #130 and will probably require extensive changes in the db client to be fixed properly. Let's keep this open as a workaround for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants