Versioned session schema #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To evolve the session data over time, it would be idea if we could associate them with a version that we can act on at deserialization time. This introduces a top-level type that just tracks the version, and the session as a raw message. We can then handle this appropriately. As part of this, we just move to go JSON serialization rather than protobufs. This is data only we consume and is used in Go code, so proto added a bunch of noise for no additional value. Because we do have existing unversioned and proto-based data out there, code has been added to detect this and parse the data correctly.
alindeman
approved these changes
Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To evolve the session data over time, it would be idea if we could associate
them with a version that we can act on at deserialization time. This introduces
a top-level type that just tracks the version, and the session as a raw
message. We can then handle this appropriately.
As part of this, we just move to go JSON serialization rather than protobufs.
This is data only we consume and is used in Go code, so proto added a bunch of
noise for no additional value.
Because we do have existing unversioned and proto-based data out there, code
has been added to detect this and parse the data correctly.