implement function validateCharacteristicValue #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix code style |
paresy
requested changes
Aug 27, 2017
| } | ||
|
|
||
| if (is_int($value)) { | ||
| if (!is_null($characteristics[$index]->getMinValue())) { /* Sollte reichen?! Wenn MinValue gesetzt ist, ist auch MaxValue gesetzt! */ |
There was a problem hiding this comment.
Ich würde Min und Max Value jeweils komplett getrennt betrachten. Nicht, dass Apple das so nutzt, aber es wäre ggf. vollständiger.
There was a problem hiding this comment.
Kein Problem, kann ich ja noch tun.
| { | ||
| $this->type = $type; | ||
| $this->requiredCharacteristics = $requiredCharacteristics; | ||
| $this->optionalCharacteristics = $optionalCharacteristics; | ||
| } | ||
|
|
||
| public function setCharacteristic(int $instanceID, $value, HAPAccessory $accessory): void | ||
| private function validateCharacteristicValue($instanceID, $value) |
There was a problem hiding this comment.
Du überprüfst zur Zeit gar nicht, ob der Typ der Variable dem entspricht was Apple erwartet, oder?
There was a problem hiding this comment.
Reicht if (is_int($value)), if (is_bool($value)), if (is_float($value)) und if (is_string($value)) nicht?
|
Ja, ist mir auch aufgefallen, wollte erstmal deiner Überprüfung abwarten, passe das wieder an. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.