Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rustc-serialize feature and bump version #22

Merged
merged 3 commits into from
Apr 21, 2021
Merged

Conversation

ordian
Copy link
Member

@ordian ordian commented Apr 21, 2021

I believe rustc-serialize is not used anywhere as it was deprecated in favor of serde a few years ago.

@@ -1,8 +1,7 @@
use core::cmp::Ordering;
use rand::Rng;
use crunchy::unroll;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for unroll! macros, previously it was imported via

#[macro_use]
extern crate crunchy;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah cool

Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this code is a left over from the fork.

We could provide serde serialize/deserialize for it if needed

@niklasad1 niklasad1 requested a review from NikVolf April 21, 2021 13:38
@ordian ordian merged commit 63f8c58 into master Apr 21, 2021
@ordian ordian deleted the ao-cleanup branch April 21, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants