Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights for v9220 #1302

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

gilescope
Copy link
Contributor

transfer ownership of uniques cheaper.
batch all now looking a bit expensive compared to batch.

no big changes.

batch all now looking a bit expensive compared to batch. no big changes.
Copy link
Contributor

@NachoPal NachoPal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggwpez
Copy link
Member

ggwpez commented May 26, 2022

I'm beta testing a new swc-web version. Feedback welcome!

@chevdor
Copy link
Contributor

chevdor commented May 27, 2022

FYI try to test using Oliver's tool => revspec 'giles-update-weights-9220' not found

@gilescope
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 1fe20e9 into master May 27, 2022
@paritytech-processbot paritytech-processbot bot deleted the giles-update-weights-9220 branch May 27, 2022 10:49
@ggwpez
Copy link
Member

ggwpez commented May 27, 2022

FYI try to test using Oliver's tool => revspec 'giles-update-weights-9220' not found

Thanks for the hint! Somehow the docker and the git autoupdate script mess up sometimes.
Need to find a better solution...
Its updated now.
I personally rather use commit hashes, since otherwise it could happen that it has a stale branch or tag.

@chevdor
Copy link
Contributor

chevdor commented May 27, 2022

I prefer using tags or branches as this is what CI will end up using. Thansk for the fix.

I am surprised to see 0 results however, even with 1% threshold.

@ggwpez
Copy link
Member

ggwpez commented May 27, 2022

I prefer using tags or branches as this is what CI will end up using. Thansk for the fix.

Okay fair enough. Still need to figure our a way to do this more reliably as it can currently spit out some 'git checkout' errors.

I am surprised to see 0 results however, even with 1% threshold.

Yea the folder is incorrect, there are no changes in polkadot-parachains/runtimes/**/src/weights/**/*.rs.
Rather use parachains/runtimes/**/src/weights/**/*.rs or more generally **/weights/*.rs.

PS: It would probably make sense to use all files from git diff as default. Then the pattern would be not so important.

gilescope added a commit that referenced this pull request May 27, 2022
batch all now looking a bit expensive compared to batch. no big changes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants