This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Lower all Assets / NFT deposits by 10x #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
commented
Jun 6, 2022
parachains/runtimes/contracts/contracts-rococo/src/constants.rs
Outdated
Show resolved
Hide resolved
shawntabrizi
commented
Jun 6, 2022
parachains/runtimes/contracts/contracts-rococo/src/constants.rs
Outdated
Show resolved
Hide resolved
|
TODO on this PR is to also reduce the base deposits which are not controlled by this formula |
|
Have you made sure that all deposits in all pallets are recorded, so changing this does not break any operation? |
gilescope
approved these changes
Jun 11, 2022
|
Base deposits are now also updated. This should be good to go. |
|
@kianenigma checked:
And these seem to be all the affected pallets. |
|
Would be good to add a |
joepetrowski
previously approved these changes
Jun 14, 2022
joepetrowski
suggested changes
Jun 14, 2022
shawntabrizi
changed the title
joepetrowski
approved these changes
Jun 14, 2022
|
@joepetrowski updated to represent what I want. Specifically to lower all Assets and NFT deposits. To do that, I also modified a function which affects deposits of some other pallets, but that is fine imo. |
bkchr
approved these changes
Jun 14, 2022
|
bot merge |
hbulgarini
pushed a commit
that referenced
this pull request
Jun 14, 2022
* lower all deposits by 10x * undo rococo stuff * Apply suggestions from code review * update asset deposits * align statemint deposit ratios Co-authored-by: joepetrowski <joe@parity.io>
Merged
joepetrowski
added a commit
that referenced
this pull request
Jun 14, 2022
* lower all deposits by 10x * undo rococo stuff * Apply suggestions from code review * update asset deposits * align statemint deposit ratios Co-authored-by: joepetrowski <joe@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: joepetrowski <joe@parity.io>
IkerAlus
added a commit
to IkerAlus/polkadot-wiki
that referenced
this pull request
Jul 20, 2022
[This PR](paritytech/cumulus#1332) updated the deposit constants needed to create an asset (and to add the metadata). Therefore the values used in the current version of this page are outdated and wrong.
DrW3RK
pushed a commit
to w3f/polkadot-wiki
that referenced
this pull request
Jul 20, 2022
[This PR](paritytech/cumulus#1332) updated the deposit constants needed to create an asset (and to add the metadata). Therefore the values used in the current version of this page are outdated and wrong.
alfarok
pushed a commit
to w3f/polkadot-wiki
that referenced
this pull request
Jul 28, 2022
[This PR](paritytech/cumulus#1332) updated the deposit constants needed to create an asset (and to add the metadata). Therefore the values used in the current version of this page are outdated and wrong.
3 tasks
tash-2s
added a commit
to tash-2s/open-emoji-battler
that referenced
this pull request
Apr 8, 2023
it is reduced before: paritytech/cumulus#1332 result: https://statemine.subscan.io/extrinsic/4234273-2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lowers all the deposits of Statemine, Statemint, Westmint, and Contracts-Rococo by 10x.
This was decided based on a high level analysis of the cost of NFT deposits compared to other platforms.
This can always be adjusted later back up if needed.
Also fixes an issue where
contracts-rococodid not use Rococo deposits.