Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge uint and bigint #24

Closed
andresilva opened this issue Aug 9, 2018 · 0 comments
Closed

Merge uint and bigint #24

andresilva opened this issue Aug 9, 2018 · 0 comments

Comments

@andresilva
Copy link
Contributor

andresilva commented Aug 9, 2018

Initially the code for big unsigned ints lived in this repo https://github.com/paritytech/bigint. At some point we copied the bigint code into https://github.com/paritytech/primitives. The problem is that we still kept committing to the original bigint repo. At this point the code in the bigint repo has seen some optimizations and is faster (u128 for limbs, dropped all assembly) and they're forgotten there. Now that bigint has moved once again, we should try to merge the current bigint code into this crate (and deprecate the bigint repo).

@dvdplm dvdplm self-assigned this Aug 23, 2018
@dvdplm dvdplm closed this as completed Aug 23, 2018
sorpaas pushed a commit that referenced this issue Jan 24, 2019
Fix missing serde impls for uints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants