Skip to content

Commit

Permalink
Contracts: Stabilize caller_is_root API (#3154)
Browse files Browse the repository at this point in the history
Can this API be marked stable? Implemented in [solang
here](hyperledger-solang/solang#1620)

---------

Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
  • Loading branch information
xermicus authored Feb 3, 2024
1 parent e349fc9 commit 966a886
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 4 deletions.
9 changes: 9 additions & 0 deletions prdoc/pr_3154.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
title: "Contracts: Stabilize caller_is_root API"

doc:
- audience: Runtime Dev
description: |
Removed the `#[unstable]` attrribute on `caller_is_root` host function.

crates:
- name: pallet-contracts
1 change: 0 additions & 1 deletion substrate/frame/contracts/src/wasm/runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1542,7 +1542,6 @@ pub mod env {

/// Checks whether the caller of the current contract is root.
/// See [`pallet_contracts_uapi::HostFn::caller_is_root`].
#[unstable]
fn caller_is_root(ctx: _, _memory: _) -> Result<u32, TrapReason> {
ctx.charge_gas(RuntimeCosts::CallerIsRoot)?;
Ok(ctx.ext.caller_is_root() as u32)
Expand Down
3 changes: 0 additions & 3 deletions substrate/frame/contracts/uapi/src/host.rs
Original file line number Diff line number Diff line change
Expand Up @@ -277,9 +277,6 @@ pub trait HostFn {
///
/// A return value of `true` indicates that this contract is being called by a root origin,
/// and `false` indicates that the caller is a signed origin.
#[deprecated(
note = "Unstable function. Behaviour can change without further notice. Use only for testing."
)]
fn caller_is_root() -> u32;

/// Clear the value at the given key in the contract storage.
Expand Down

0 comments on commit 966a886

Please sign in to comment.