-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tolerance to nom pool pending rewards try-state #1236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the convo in https://github.com/paritytech/polkadot-sdk/pull/1236/files#r1308580829, I think this is one of those problem for which no ideal solution exists so I hope to accelerate either of the fixes by approving.
FWIW though, I think given the current way that this pallet is coded, the reward pools always having ED is actually NOT enforced, so instead of adding a tolerance to the check, the check should be strict, but it should only emit a warning instead of panicking.
…/fix-nom-pool-try-state
I have replaced the ensure check with a warning as suggested. |
Closes paritytech#158 In our last FRAME call it was discussed that a likely solution to the ED imbalances is lazily fixing the pools as they are interacted with. So, we should add some tiny tolerance to the try-state checks so next time there's an ED change they don't start failing until they've all been interacted with. ### Update 12 Sept Rather than adding tolerance, have replaced the `ensure` with a warning. --------- Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com>
Closes #158
In our last FRAME call it was discussed that a likely solution to the ED imbalances is lazily fixing the pools as they are interacted with.
So, we should add some tiny tolerance to the try-state checks so next time there's an ED change they don't start failing until they've all been interacted with.
Update 12 Sept
Rather than adding tolerance, have replaced the
ensure
with a warning.