-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #1409 partially #1603
Merged
Merged
Revert #1409 partially #1603
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9b3b7ca
Revert #1409 partially
vstakhov 63a2577
Fmt iter
vstakhov bfdfa7e
Merge branch 'master' into vstakhov-network-bridge-refactor-fix
vstakhov 73e0e62
Merge branch 'master' into vstakhov-network-bridge-refactor-fix
vstakhov b4358a7
Merge branch 'master' into vstakhov-network-bridge-refactor-fix
vstakhov 94e50f9
Remove todo as it is not needed in fact
vstakhov eadae49
Merge branch 'master' into vstakhov-network-bridge-refactor-fix
vstakhov 40a7579
Merge branch 'master' into vstakhov-network-bridge-refactor-fix
vstakhov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This metric is useful, why not keep it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR just reverts the "bad things", so I've decided to leave it as simple and quick as possible. I'm working on a better version in the meantime on top of this one.