-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
authorithy-discovery: Make changing of peer-id while active a bit more robust #3786
Open
alexggh
wants to merge
47
commits into
master
Choose a base branch
from
alexaggh/fix_change_node_id_at_restart
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
0103c7f
authorithy-discovery: Make changing of peer-id while active a bit mor…
alexggh 4172677
Make clippy happy
alexggh 64f38d2
Fix warnings
alexggh ce87688
Refactor gossip support
alexggh bd69a55
Merge remote-tracking branch 'origin/master' into fix_change_node_id_…
alexggh a69ba99
Make clippy happy
alexggh 311aade
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh 1305763
Some other hacks
alexggh 7e16e58
Add more changes
alexggh a82ebed
More refactoring
alexggh d569ab3
A bit more refactoring
alexggh 1c9a40d
A few more improvements
alexggh 91e647c
Fixup even more
alexggh 0a53ec2
Another something
alexggh ef6ddb6
Fixup everything
alexggh b3eb615
Post refactoring
alexggh f6d4b29
Fixup Cargo's
alexggh b41cdf7
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh 1ae1759
Make clippy happy
alexggh 7b56bc8
Some minor tweaks
alexggh d610df6
Minor updates
alexggh 4263dc4
Minor review feedback
alexggh 4d7b164
Add authorithy-discovery-unittests
alexggh 7cc3333
Add unittest for gossip-support changes
alexggh fabdb4b
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh 42afffc
Simplify indentation levels
alexggh 28ac0a2
Minor cleanups
alexggh 95950a7
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh bd21fda
Update litep2p
alexggh 57f1b38
Use put_valut_to from litep2p
alexggh 9f56b02
Minor feedback
alexggh 6d196c4
Minor changes
alexggh 9979f8f
Minor updates
alexggh fd5dc46
Integrate with https://github.com/paritytech/litep2p/pull/96
alexggh 20e351e
Fix warning on quorum failed
alexggh 98398e3
Reconnect only if new peer ids pop-up
alexggh 8066044
Revert kademlia removal
alexggh 8eef5c3
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh b4fe357
Update cargo.lock
alexggh 97f09a3
Merge branch 'master' into alexaggh/fix_change_node_id_at_restart
alexggh 586a0f1
Merge remote-tracking branch 'origin/master' into alexaggh/fix_change…
alexggh 09b6306
Update substrate/client/network/src/litep2p/mod.rs
alexggh fb534b5
Update polkadot/node/network/gossip-support/src/tests.rs
alexggh 7399dc5
Update substrate/client/authority-discovery/src/worker/tests.rs
alexggh 17df838
Update assert messages
alexggh 3313fd7
Address review feedback
alexggh 999a710
Use a single signature
alexggh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be remove before merging once: paritytech/litep2p#96, gets merged.