Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the faucet continues to work when there is a runtime upgrade #223

Closed
Tracked by #3
rzadp opened this issue Mar 8, 2023 · 3 comments · Fixed by #275 or #376
Closed
Tracked by #3

Make sure the faucet continues to work when there is a runtime upgrade #223

rzadp opened this issue Mar 8, 2023 · 3 comments · Fixed by #275 or #376
Assignees
@mutantcornholio

Comments

@rzadp
Copy link
Contributor

rzadp commented Mar 8, 2023

Right now, when there is a runtime upgrade, the faucet fails with 1010: Invalid Transaction: Transaction has a bad signature until it is restarted.

Maybe we could include a runtime upgrade in the E2E test and check that it continues to work?

Possible solutions

I don't know the exact cause of failure, so I don't know what the solutions might be.
But potentially:

  • Change HTTP provider to WS provider
  • See if we're using the HTTP provider somehow incorrectly?
@mordamax mordamax mentioned this issue Apr 5, 2023
Closed
mutantcornholio added a commit that referenced this issue May 26, 2023
@mutantcornholio
Switching to WS provider
5ddd78e 
Fixes #223

Tested using this method: https://polkadot.js.org/docs/api/examples/promise/upgrade-chain,
changing provider from HTTP to WS actually seems to do the trick.

The original plan was to add runtime upgrade to e2e tests, however
supporting that test setup seems to be a bit too much. It basically
requires an additional zombienet setup, which would also be different
for local development and CI.
Basically, that would be a whole new test pack with its own setup,
specifically for an issue in of `@polkadot/api`.
Still can be done, but seems to be a bit too much.
@mutantcornholio mutantcornholio mentioned this issue May 26, 2023
Merged
mutantcornholio added a commit that referenced this issue May 26, 2023
@mutantcornholio
Switching to WS provider
8076e97 
Fixes #223

Tested using this method: https://polkadot.js.org/docs/api/examples/promise/upgrade-chain,
changing provider from HTTP to WS actually seems to do the trick.

The original plan was to add runtime upgrade to e2e tests, however
supporting that test setup seems to be a bit too much. It basically
requires an additional zombienet setup, which would also be different
for local development and CI.
Basically, that would be a whole new test pack with its own setup,
specifically for an issue in of `@polkadot/api`.
Still can be done, but seems to be a bit too much.
mutantcornholio added a commit that referenced this issue May 26, 2023
@mutantcornholio
Switching to WS provider (#275)
cc0eb72 
Fixes #223

Tested using this method:
https://polkadot.js.org/docs/api/examples/promise/upgrade-chain,
changing provider from HTTP to WS actually seems to do the trick.

The original plan was to add runtime upgrade to e2e tests, however
supporting that test setup seems to be a bit too much. It basically
requires an additional zombienet setup, which would also be different
for local development and CI.
Basically, that would be a whole new test pack with its own setup,
specifically for an issue in of `@polkadot/api`.
Still can be done, but seems to be a bit too much.
@mutantcornholio
Copy link
Contributor

Reopening the issue, as changing the provider didn't actually fix the problem

@mutantcornholio mutantcornholio mentioned this issue Jun 21, 2023
Closed
@mutantcornholio
Copy link
Contributor

Moving to blocked until next occurrence

@mordamax
Copy link
Contributor

afaik devops team has it in a list of todo - to restart faucets.. @PierreBesson @ArshamTeymouri correct?

@rzadp rzadp mentioned this issue Oct 17, 2023
Closed
mutantcornholio added a commit that referenced this issue Mar 5, 2024
@mutantcornholio
Adding runtimeRestarter
b131f0d 
Fixes #223

+ Adding prom-client dependency, because it was removed from
@eng-automation/js (rightfully so)
@mutantcornholio mutantcornholio mentioned this issue Mar 5, 2024
Merged
mutantcornholio added a commit that referenced this issue Mar 6, 2024
@mutantcornholio
Adding runtimeRestarter
8b00bfc 
Fixes #223

+ Adding prom-client dependency, because it was removed from
@eng-automation/js (rightfully so)
mutantcornholio added a commit that referenced this issue Mar 6, 2024
@mutantcornholio
Adding runtimeRestarter (#376)
ac079a8 
Fixes #223

+ Adding prom-client dependency, because it was removed from
@eng-automation/js (rightfully so)
forgetso added a commit to prosopo/polkadot-testnet-faucet that referenced this issue Mar 26, 2024
@forgetso @mutantcornholio
@dependabot @Bullrich
lockfile update (#3)
b397ef5 
* lockfile update

* Upgrade deps

* Package-lock.json

* Updating e2e tests readme (paritytech#375)

* Fixing e2e readme link

* Adding runtimeRestarter (paritytech#376)

Fixes paritytech#223

+ Adding prom-client dependency, because it was removed from
@eng-automation/js (rightfully so)

* Updating zombinenet verion in e2e docs (paritytech#378)

@josepot has reported an error with `@zombienet/cli@1.3.43`, while the
latest version worked

* Using PAPI for e2e tests (paritytech#379)

* Currently, e2e types are generated on postinstall and prebuild steps,
which requires metadata to be available in Docker image, even though
it's not technically used in the application code. I think separating
things would make things more complicated, but it's possible.
* Couldn't undestand the reason for having two different COPY
instructions
in Dockerfile, but that doesn't live well with generating types in
postinstall, so merging those two
* .scale metadata files from Zombienet hosts saved in the codebase,
in order to be able to compile the code separately from running
Zombienet

* Update dependencies

* yarn.lock

* Bump the npm_and_yarn group across 2 directories with 2 updates (paritytech#381)

* removed base url (paritytech#382)

This removes the base url, making the website work on the root of the
domain.

Also, by doing this change, and having set up the dns, this resolves
paritytech#348

* Update deps

* Update API calls

* Silence polkadot API type errors

* Update captcha type to image and set width of captcha container

* remove grid class

* switch back to PJS. change port number

* remove prettier deps

* update port

* set procaptcha details

* fix dropdown z-index

* Fix z-indexes

* Change mock provider version

* remove console.errors

---------

Co-authored-by: Yuri Volkov <0@mcornholio.ru>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Javier Bullrich <javier@bullrich.dev>
forgetso added a commit to prosopo/polkadot-testnet-faucet that referenced this issue Apr 29, 2024
@forgetso @mutantcornholio
@dependabot @Bullrich @wilwade @mordamax
Upstream merge (#4)
722c604 
* Updating e2e tests readme (paritytech#375)

* Fixing e2e readme link

* Adding runtimeRestarter (paritytech#376)

Fixes paritytech#223

+ Adding prom-client dependency, because it was removed from
@eng-automation/js (rightfully so)

* Updating zombinenet verion in e2e docs (paritytech#378)

@josepot has reported an error with `@zombienet/cli@1.3.43`, while the
latest version worked

* Using PAPI for e2e tests (paritytech#379)

* Currently, e2e types are generated on postinstall and prebuild steps,
which requires metadata to be available in Docker image, even though
it's not technically used in the application code. I think separating
things would make things more complicated, but it's possible.
* Couldn't undestand the reason for having two different COPY
instructions
in Dockerfile, but that doesn't live well with generating types in
postinstall, so merging those two
* .scale metadata files from Zombienet hosts saved in the codebase,
in order to be able to compile the code separately from running
Zombienet

* Bump the npm_and_yarn group across 2 directories with 2 updates (paritytech#381)

* removed base url (paritytech#382)

This removes the base url, making the website work on the root of the
domain.

Also, by doing this change, and having set up the dns, this resolves
paritytech#348

* Added markup code generation (paritytech#383)

It generates a JSON object inside the header following the instructions
from:
https://developers.google.com/search/docs/appearance/structured-data/faqpage

It parses the information of the markdown text to generate this json
object.

This resolves paritytech#277

* Updated actions to latest and added retention period (paritytech#384)

We currently don't have an artifact retention period, so it defaults to
90 days.

While the artifact for the site is not too big, having one build per
push and PR can quickly accumulate the amount and make us hit our hard
limit.

By adding a limit to the retention day of 5 days we ensure that we get
rid of the old artifacts faster than waiting for two whole months.

I also updated all the actions version to latest release

* Bump the npm_and_yarn group across 1 directory with 1 update (paritytech#385)

* Bump the npm_and_yarn group across 1 directory with 1 update (paritytech#387)

* Update Frequency Faucet URL (paritytech#393)

As the Frequency Faucet now also supports Frequency Paseo testnet in
addition to the Rococo one, the url is being set to a generic one
instead of specific for the network.

https://faucet.testnet.frequency.xyz/

* moved tag-client to work in pull_request_target (paritytech#394)

It fails when an external contributors make a PR.

This will fix that issue.

* Merge latest upstream and use a transaction queue to send txs to nodes

* Add MIT LICENSE (paritytech#395)

* bump to polkadot 10.13.1

* lockfile

* yarn.lock

* yarn.lock

* yarn.lock

* yarn.lock

* yarn.lock client

* Fix test mock

* Add @polkadot/util to dev dependencies

* Address comments from @mutantcornholio

---------

Co-authored-by: Yuri Volkov <0@mcornholio.ru>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Javier Bullrich <javier@bullrich.dev>
Co-authored-by: Wil Wade <wil@wilwade.com>
Co-authored-by: Maksym H <1177472+mordamax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mutantcornholio mutantcornholio

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mutantcornholio @mordamax @rzadp