client: Added a Dockerimage #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzadp
previously approved these changes
Mar 20, 2023
PierreBesson
suggested changes
Mar 20, 2023
Bullrich
added a commit
that referenced
this pull request
Mar 21, 2023
Migrate the site to run in SvelteKit instead of plain Svelte. This will allow us to run as a Docker image required by #238 Almost all of the code remains the same, the biggest difference is the new location of files (as SvelteKit requires particular directories) or the modification of config files (that were replaced by the new configs). Another small change is that public variables now need the `PUBLIC_` prefix instead of the `VITE_` prefix, so we also had to change that value in the CI.
Bullrich
force-pushed
the
bullrich/client/docker-image
branch
from
1c5a8de
to
fac0382
Compare
PierreBesson
previously approved these changes
Mar 21, 2023
This action tests if the image is being built correctly
Bullrich
force-pushed
the
bullrich/client/docker-image
branch
from
fac0382
to
00301a6
Compare
|
Hi @PierreBesson! I added the logic to build the image and publish it in Could you please review that file and let me know if it is as intended? I'm afraid my knowledge of gitlab's deployment script is not very broad |
Bullrich
force-pushed
the
bullrich/client/docker-image
branch
from
822d7f8
to
5bd2d8e
Compare
It was building the root one when it had to build the one in the client
Bullrich
force-pushed
the
bullrich/client/docker-image
branch
from
5bd2d8e
to
44467db
Compare
Bullrich
dismissed stale reviews from rzadp and PierreBesson
Too many files changed. I need this to be reviewed again
This way the final image occupies less space
Bullrich
force-pushed
the
bullrich/client/docker-image
branch
from
9650a7e
to
4712f4f
Compare
|
Should we update |
mordamax
approved these changes
Mar 24, 2023
Yes, this make sense. I'll add the commit for that. |
sergejparity
approved these changes
Mar 27, 2023
Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a docker image for the client, in the case that we want to deploy the site to any other platform aside from GitHub Pages