Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse matrix helpers from @eng-automation/testing #412

Merged
merged 5 commits into from
May 24, 2024
Merged

Conversation

rzadp
Copy link
Contributor

@rzadp rzadp commented May 22, 2024

No description provided.

@rzadp rzadp requested a review from a team as a code owner May 22, 2024 11:22
@rzadp
Copy link
Contributor Author

rzadp commented May 22, 2024

Running into some weird issues with yarn install with this.

@mutantcornholio
Copy link
Contributor

@rzadp well, one way around it is to remove yarn.lock

@Bullrich
Copy link
Contributor

We can also make eng-automation work both with es modules and with ES2020 for every case

@rzadp
Copy link
Contributor Author

rzadp commented May 22, 2024

@rzadp well, one way around it is to remove yarn.lock

It helped locally, but not on CI 🤔

@rzadp
Copy link
Contributor Author

rzadp commented May 24, 2024

Regenerating yarn.lock with yarn version 1.22.22 helped. Thanks @mutantcornholio!

@rzadp rzadp merged commit 549c5e5 into main May 24, 2024
9 checks passed
@rzadp rzadp deleted the rzadp/re-usetesting branch May 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants