This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[zombienet] more logs for smoke tests #4571
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
added
B0-silent
pepoviola
approved these changes
Dec 23, 2021
|
|
||
| # [[relaychain.nodes.overrides]] | ||
| # local_path = "../../target/release/polkadot" | ||
| # remote_name = "wonderland" |
There was a problem hiding this comment.
Hi @drahnr, just a comment on this config. Zombienet use remote_name to create the file in the container, in this case wonderland but this config use the default command (e.g polkadot) so wonderland will not be used.
Related issue in zombienet paritytech/zombienet#46 to explore make this optional.
Thx!
There was a problem hiding this comment.
In that case, zombienet should point me to precisely this conflict with line numbers 🙃
There was a problem hiding this comment.
Sounds good! I open this issue to track this.
Thanks!
drahnr
force-pushed
the
bernhard-zombienet-more-logs
branch
from
38c577f
to
ac0bb6e
Compare
|
@sandreim please merge unless this is obsoleted by your work, in that case please close |
|
closed since #4901 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase logs for smoke tests for easier verification and turnaround.
Also leaves local overrides commented, to avoid one extra roundtrip.