This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add metrics for out of view statement distribution errors #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A3-in_progress
github-actions
bot
added
A0-please_review
drahnr
reviewed
Feb 23, 2022
drahnr
reviewed
Feb 23, 2022
drahnr
reviewed
Feb 23, 2022
drahnr
reviewed
Feb 23, 2022
drahnr
reviewed
Feb 23, 2022
drahnr
reviewed
Feb 23, 2022
drahnr
approved these changes
Feb 23, 2022
sandreim
reviewed
Feb 23, 2022
sandreim
approved these changes
Feb 23, 2022
|
I have slightly reworked that addressing @sandreim comments. |
|
bot merge |
|
Error: Checks failed for 4f1808b |
…distribution-metrics
drahnr
reviewed
Feb 25, 2022
drahnr
reviewed
Feb 25, 2022
drahnr
reviewed
Feb 25, 2022
drahnr
approved these changes
Feb 25, 2022
drahnr
approved these changes
Feb 25, 2022
|
bot merge |
|
Waiting for commit status. |
paritytech-processbot
bot
deleted the
vstakhov-statement-distribution-metrics
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to cover the situation when we loose some messages during the statement distribution propagation and it causes a chain of the peer reputation changes requests. The idea is to store the count of such a messages in a metric and avoid reputation change flood constrained per relay parent block.