Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create AND DISTINCIT rule #11

Closed
Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #51
Closed

Create AND DISTINCIT rule #11

Bullrich opened this issue Jul 6, 2023 · 0 comments · Fixed by #51
Assignees
@Bullrich
Milestone
Project launch

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Jul 6, 2023

Reference: https://github.com/paritytech/pr-custom-review#and-distinct-rule-syntax-
@Bullrich Bullrich added this to the Project launch milestone Jul 6, 2023
@Bullrich Bullrich self-assigned this Jul 6, 2023
@Bullrich Bullrich linked a pull request Aug 21, 2023 that will close this issue
Created And Distinct Rule #51
Merged
@Bullrich Bullrich mentioned this issue Aug 21, 2023
Merged
Bullrich added a commit that referenced this issue Aug 22, 2023
@Bullrich
Created And Distinct Rule (#51)
28c4ee2 
Resolves #11

This is the most complicated of all the rules.

It evaluates the functionality of the `And Distinct` parameter.

It does so by splitting the elements into individual cases and brute
forcing matches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
None yet
Projects
None yet
Milestone
Project launch
Development

Successfully merging a pull request may close this issue.

Created And Distinct Rule paritytech/review-bot
1 participant
@Bullrich