Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get all the team members #88

Closed
Bullrich opened this issue Oct 3, 2023 · 0 comments · Fixed by #90
Closed

Get all the team members #88

Bullrich opened this issue Oct 3, 2023 · 0 comments · Fixed by #90
Assignees
@Bullrich
Labels
bug Something isn't working

Comments

@Bullrich
Copy link
Contributor

Bullrich commented Oct 3, 2023

When calling the method to get the team members, GitHub returns 30 by default.

We need to get all the members from a team.
@Bullrich Bullrich added the bug Something isn't working label Oct 3, 2023
@Bullrich Bullrich self-assigned this Oct 3, 2023
@Bullrich Bullrich mentioned this issue Oct 3, 2023
Merged
Bullrich added a commit that referenced this issue Oct 3, 2023
@Bullrich
Fixed bug where only 30 members where shown (#90)
a2988bc 
Fixed a pagination issue where the system was only obtaining the first
30 membes of a team.

By adding the [pagination method of
Octokit](https://actions-cool.github.io/octokit-rest/guide/05_pagination/)
we can obtain all of the results at once.

Updated project version to 2.0.1 to generate a new release.

This fixes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bullrich Bullrich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bug where only 30 members where shown paritytech/review-bot
1 participant
@Bullrich