-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added cron job to comment ongoing referenda on PRs #28
Conversation
0152882
to
c647ce8
Compare
8274cff
to
250c061
Compare
This is a simple test to find the correct list of referendas and their information. It's a WIP
Now it can be reused
This way it won't call the comment function
There were some problems setting it up with gh cli. I was missing some variables
250c061
to
2dcdd81
Compare
@Bullrich is it only for new referendas? |
Not yet, this first version will only obtain the status of ongoing referendas. After this I can make a second PR handling completed referendas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see it working for a several days on stg before implementation
How you think the further referenda status changes will be tracked?
It is more consistent
Hi @rzadp! It is ready for review. I don't really know what tests I can add aside from ensuring that it doesn't crash when fetching the referenda. If you have any suggestions, please, let me know. |
2ffb2bf
to
ee37a69
Compare
Me too. Do you know how to setup an alternative testing environment so I can start testing it?
You mean when they close? It should be doable using @rzadp's method, so the logic wouldn't change too much. |
answered in our matrix channel - could be Westend -> Collectives with making us fellows there installed to paritytech-stg?
as described here paritytech/eng-automation#2 |
Now we don't need to use subsquare's API
Can not properly be a one liner as it brings problems with the quotes. Dividing it into two lines makes the process easier
Added functionality for a cron job to iterate over all ongoing referendas and compare them to the open PRs. If there is any match on the remark, and the referenda has been opened after the last time the action was run, it will comment a link to the referenda in Polkassembly.
This is intended to resolve the requirements in polkadot-fellows/RFCs#57