-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Popup based on Figma files #1039
Fix Popup based on Figma files #1039
Conversation
There are still some things missing - but has to do with the way that smoldot API is implemented. Another non-implemented part of the pop-up is the
|
…dnkod/substrate-connect into nik-extension-popup-based-onf-figma
<div className="icon w-7"> | ||
{knownChains.includes(icon) ? icon : "?"} | ||
</div> | ||
<div className="pl-2">{network}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super confident in this. This value is untrusted and entirely decided by the website. A website could have a name that is super long or has tons of weird unicode characters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure I understand - this part of code is showing the network name. We don't show the app's name. So even if there is a custom chain/parachain that is named: 123AS$@#$SomethingMoreAnd123;'_'ThisCanGoOnUntilItIsVeryLong
, still will just appear as the "network name" and icon as ?
. I'm not sure what the vulnerability is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no "vulnerability", just someone could completely destroy your CSS with a very long name, unless you made sure that it can't happen
Fixes #977