-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Unify Prometheus library with libp2p #12699
Comments
My two cents: I find the entire Prometheus code extremely over-engineered. The Prometheus format is dead simple, and I don't understand why we even need a third party library for that. |
If you write an ergonomic wrapper for those hashmaps and serializer to text format you'll end up with a custom library anyway, so might as well use something off-the-shelf. I think the biggest value is in more complex kinds of metrics like histograms and summaries, not sure how widely used they are in Substrate though. |
If someone was do tackle the migration, I'm wondering what are the chances of getting it upstreamed in Substrate. |
I mean someone can tackle this issue. Probably not really complicated.
However, I don't get this? Prometheus is some standard, so both libraries are probably already compatible and not change your monitoring? |
|
Okay, thank you for the explanation! |
Substrate currently uses
prometheus
library, while libp2p usesprometheus-client
, which is now the official Rust library, see libp2p change: libp2p/rust-libp2p#2442In our node we have both Substrate and another libp2p-based library used and it would be ideal to push all metrics into the same endpoint, but due to completely different libraries used this is not currently possible.
Please consider switching to
prometheus-client
library in Substrate, it will likely receive more attention going forward.The text was updated successfully, but these errors were encountered: