Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

It is hard to distinguish events from a utility.batch call #5639

Closed
xlc opened this issue Apr 15, 2020 · 3 comments
Closed

It is hard to distinguish events from a utility.batch call #5639

xlc opened this issue Apr 15, 2020 · 3 comments
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@xlc
Copy link
Contributor

xlc commented Apr 15, 2020

I made a utility.batch call with 8 calls, and they emit 9 events. It is not easy to identify which call emit which event.

A possible solution is have utility.batch emit a completed event after each dispatch.

But for calls dispatched in other ways, such as from scheduler, it is still not easy to distinguish the source of the event.

Maybe we can emit event in pre_dispatch and post_dispatch? but that sounds like some large overhead? But if the cost of an event is very low, maybe the overhead is acceptable?

Otherwise this can be part of #2082

@bkchr bkchr added J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Apr 15, 2020
@xlc
Copy link
Contributor Author

xlc commented Apr 16, 2020

Emit event from pre_dispatch / post_dispatch won't work, because they are only called when applying extrinsic.

@xlc
Copy link
Contributor Author

xlc commented Sep 10, 2020

One solution is somehow support nested event. But that sounds like a large-ish change.

@xlc
Copy link
Contributor Author

xlc commented Jul 29, 2021

Closed by #9462

@xlc xlc closed this as completed Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
None yet
Development

No branches or pull requests

2 participants