Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

reset events before apply runtime upgrade #10620

Merged
merged 6 commits into from Jan 12, 2022
Merged

reset events before apply runtime upgrade #10620

merged 6 commits into from Jan 12, 2022

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Jan 9, 2022 •
edited

closes #10603

polkadot companion: paritytech/polkadot#4696
cumulus companion: paritytech/cumulus#894

@xlc xlc requested a review from andresilva as a code owner January 9, 2022 21:19
bkchr
bkchr reviewed Jan 10, 2022
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just some nitpicks.

frame/system/src/lib.rs Outdated Show resolved Hide resolved
frame/executive/src/lib.rs Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented Jan 10, 2022

It also doesn't compile.

@bkchr bkchr added this to In progress in Runtime via automation Jan 10, 2022
@bkchr bkchr added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. labels Jan 10, 2022
@xlc xlc requested a review from athei as a code owner January 10, 2022 09:40
bkchr
bkchr approved these changes Jan 10, 2022
View reviewed changes
frame/system/src/lib.rs Outdated Show resolved Hide resolved
Runtime automation moved this from In progress to Needs Audit Jan 11, 2022
@bkchr
Copy link
Member

bkchr commented Jan 11, 2022

@xlc we need a companion for this.

This was referenced Jan 12, 2022
Merged
Merged
@bkchr
Copy link
Member

bkchr commented Jan 12, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 306be17 into paritytech:master Jan 12, 2022
Runtime automation moved this from Needs Audit to Done Jan 12, 2022
@xlc xlc deleted the update-events branch January 12, 2022 09:26
@shawntabrizi shawntabrizi moved this from Done to Archive in Runtime Jan 20, 2022
@librelois librelois mentioned this pull request Feb 7, 2022
Closed
@nanocryk nanocryk mentioned this pull request Feb 9, 2022
Merged
2 tasks
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@xlc @bkchr @grishasobol
reset events before apply runtime upgrade (paritytech#10620)
20588f9 
* reset events before apply runtime upgrade

* fix tests

* add test

* update comment

* Update frame/system/src/lib.rs

* trigger CI

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@xlc @bkchr @ark0f
reset events before apply runtime upgrade (paritytech#10620)
d6cdceb 
* reset events before apply runtime upgrade

* fix tests

* add test

* update comment

* Update frame/system/src/lib.rs

* trigger CI

Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@bkchr bkchr bkchr approved these changes

@andresilva andresilva Awaiting requested review from andresilva andresilva is a code owner

@athei athei Awaiting requested review from athei athei is a code owner

@kianenigma kianenigma Awaiting requested review from kianenigma

@thiolliere thiolliere Awaiting requested review from thiolliere

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Events from on_runtime_upgrade are unavailable
3 participants
@xlc @bkchr @shawntabrizi