Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Unignore test #11097

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Unignore test #11097

merged 1 commit into from
Mar 29, 2022

Conversation

wigy-opensource-developer
Copy link
Contributor

The test broke when the transaction pool synchronization appeared in the instantiated client.

Closes #8681

@wigy-opensource-developer wigy-opensource-developer added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 23, 2022
@wigy-opensource-developer wigy-opensource-developer added this to Triage in Networking (Outdated) via automation Mar 23, 2022
@wigy-opensource-developer wigy-opensource-developer requested review from tomaka and NikVolf and removed request for tomaka March 23, 2022 09:48
@wigy-opensource-developer
Copy link
Contributor Author

Of course my solution is a bit short-sighted, because similar to the end of the match it completely ignores whatever else happens on these connections and only cares about the extra protocol foo.

@wigy-opensource-developer wigy-opensource-developer requested a review from a team March 23, 2022 10:24
@bkchr
Copy link
Member

bkchr commented Mar 29, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 41567c3 into master Mar 29, 2022
Networking (Outdated) automation moved this from Triage to Done Mar 29, 2022
@paritytech-processbot paritytech-processbot bot deleted the wigy-unignore-notification-test branch March 29, 2022 20:33
bkchr added a commit that referenced this pull request Mar 31, 2022
bkchr added a commit that referenced this pull request Apr 11, 2022
* Prepare for rust stable 1.59

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

* Ensure we run the UI tests in CI

* use staging ci image

* More test updates

* Unignore test (#11097)

* empty commit for pipeline rerun

* empty commit for pipeline rerun

* Try to make clippy happy

* More clippy fixes

* FMT

* ci image production

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* Prepare for rust stable 1.59

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

* Ensure we run the UI tests in CI

* use staging ci image

* More test updates

* Unignore test (paritytech#11097)

* empty commit for pipeline rerun

* empty commit for pipeline rerun

* Try to make clippy happy

* More clippy fixes

* FMT

* ci image production

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Prepare for rust stable 1.59

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

* Ensure we run the UI tests in CI

* use staging ci image

* More test updates

* Unignore test (paritytech#11097)

* empty commit for pipeline rerun

* empty commit for pipeline rerun

* Try to make clippy happy

* More clippy fixes

* FMT

* ci image production

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Un-ignore networking test
3 participants