Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Prepare for rust stable 1.60 #11138

Merged
merged 17 commits into from
Apr 11, 2022
Merged

Prepare for rust stable 1.60 #11138

merged 17 commits into from
Apr 11, 2022

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Mar 29, 2022

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Mar 29, 2022
@bkchr bkchr requested a review from a team as a code owner March 29, 2022 21:04
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So hopefully I won't have to copy&paste the CI error output in the future anymore 😆

primitives/api/test/tests/trybuild.rs Show resolved Hide resolved
@bkchr bkchr changed the title Prepare for rust stable 1.59 Prepare for rust stable 1.60 Apr 8, 2022
@bkchr
Copy link
Member Author

bkchr commented Apr 8, 2022

@alvicsam I finally created the corresponding polkadot pr: paritytech/polkadot#5282

Sorry for the delay! In the meanwhile rust has released 1.60. Could you please update the image directly to 1.60. Ty!

@alvicsam
Copy link
Contributor

alvicsam commented Apr 8, 2022

@bkchr staging image has already 1.60 version. However, the nightly version is updated manually. Currently it's 1.58 (nightly-2021-11-08), should I update it to 1.62 (nightly-2022-04-08)?

@bkchr
Copy link
Member Author

bkchr commented Apr 8, 2022

Yeah, please also update the nightly.

@alvicsam
Copy link
Contributor

alvicsam commented Apr 8, 2022

Nightly rust is updated, the latest pipeline used stable 1.60 and nightly 1.62

@alvicsam alvicsam requested a review from chevdor April 11, 2022 09:18
@bkchr bkchr merged commit b647138 into master Apr 11, 2022
@bkchr bkchr deleted the bkchr-rust-1.59 branch April 11, 2022 09:21
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
* Prepare for rust stable 1.59

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

* Ensure we run the UI tests in CI

* use staging ci image

* More test updates

* Unignore test (paritytech#11097)

* empty commit for pipeline rerun

* empty commit for pipeline rerun

* Try to make clippy happy

* More clippy fixes

* FMT

* ci image production

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
* Prepare for rust stable 1.59

Besides preparing the UI tests this also adds a new script update-rust-stable.sh script for
simplifying the update of a rust stable version. This script will run all UI tests for the new
rust stable version and updating the expected output.

* Ensure we run the UI tests in CI

* use staging ci image

* More test updates

* Unignore test (paritytech#11097)

* empty commit for pipeline rerun

* empty commit for pipeline rerun

* Try to make clippy happy

* More clippy fixes

* FMT

* ci image production

Co-authored-by: alvicsam <alvicsam@gmail.com>
Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants