Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add Freeze/Thaw events and tests #13779

Merged
merged 6 commits into from
Apr 21, 2023

Conversation

sea212
Copy link
Contributor

@sea212 sea212 commented Mar 31, 2023

This PR adds a Freeze and Thaw event. The respective event is emitted whenever some balance is frozen or thawed. This is a continuation of #12287. I decided to split PRs to maintain transparency and to not invalidate the previous audit, see #12287 (comment) for more information.

The logic remained the same as in #12287, however two new events Freeze and Thaw were added that cover the case that update_freezes is invoked instead of the deprecated update_locks. The tests are also equal, except that the calls were adjusted to the freeze case. Those are the test scenarios:

Freezes = []        --> [10]      // emits Frozen(..., amount=10)
Freezes = [10]      --> [15]      // emits Frozen(..., amount=5)
Freezes = [15]      --> [15, 20]  // emits Frozen(..., amount=5)
Freezes = [15, 20]  --> [17, 20]  // emits nothing
Freezes = [17, 20]  --> [17, 15]  // emits Thawed(..., amount=3)
Freezes = [17, 15]  --> [15]      // emits Thawed(..., amount=2)
Freezes = [15]      --> []        // emits Thawed(..., amount=15)

I decided to follow the approach of adding new events for functionality added in the Fungible implementation. Now a Lock and Unlock event exists for calls into the deprecated update_locks, whereas Freeze and Thaw also exist to cover calls into the new update_freezey function. Should we move forward with that approach?

@ggwpez ggwpez added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 31, 2023
Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
@jsidorenko
Copy link
Contributor

Could you pls sync your branch with master?

@ggwpez
Copy link
Member

ggwpez commented Apr 14, 2023

bot rebase

@paritytech-processbot
Copy link

Rebased

@bkchr bkchr merged commit 471b49b into paritytech:master Apr 21, 2023
@sea212 sea212 deleted the balances-add-freeze-events branch April 21, 2023 18:53
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/april-updates-for-substrate-and-polkadot-devs/2764/1

@louismerlin louismerlin added D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited and removed D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited labels May 4, 2023
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* Add Freeze/Thaw events and tests

* Remove duplicate docstring

* Correct spelling error

* Cargo fmt

* Use proper punctuation in docstring

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>

---------

Co-authored-by: Jegor Sidorenko <5252494+jsidorenko@users.noreply.github.com>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D1-audited 👍 PR contains changes to fund-managing logic that has been properly reviewed and externally audited T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants